HTTP: specify Domain attribute in user session cookie #3165
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerardsn would you mind testing this in Firefox and/or Safari? |
|
Still the same
|
What's the english error? |
|
dunno. I've set the OS and browser language to English but the error message does not change |
|
@reinkrul should we close this for now? |
|
I don't see much reason to fix this right now. I believe it might be rather complex because we automatically redirect (with location headers) when landing on the holder site, and then cookies might not be accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie is currently rejected by Safari/Firefox
Fixes #3164